Fix a bug in Nieves CCQE hadron tensor #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nieves CCQE model uses pre-calculated hadron tensor in the rest frame of initial nucleon and q should be in z direction. Now we use coordinate system in the rest frame of nucleus. We need to do boost and rotation to do the transfermation.
kjplows
added
enhancement
kjplows
moved this from PR in progress
to Open pull requests
in SBN software development
kjplows
approved these changes
Jan 8, 2026
kjplows
left a comment
kjplows
left a comment
There was a problem hiding this comment.
Splines for the new hadron tensor at Nieves are visible at DocDB 45139, physics behind this change at DocDB 45136.
Both were presented at the cross-section meeting on Monday, January 5th, 2026. The outcome of that meeting was to approve this bugfix and merge it into the SBN fork of Generator.
Many thanks @LiangLiu212 for all your hard work, this was an excellent catch!
github-project-automation
bot
moved this from Open pull requests
to Done
in SBN software development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nieves CCQE model uses reduced hadron tensor in the rest frame of initial nucleon and q should be in z direction. Now we use coordinate system in the rest frame of nucleus. We need to do boost and rotation to do the transfermation.